Bug fixes and drastic improvement in frame move smoothness #1864

MrTJP · 2024-06-02T16:03:24Z

Fix case of connectable block entities re-connecting to blocks in process of being removed during their neighbor update call. Same issue was fixed for parts in af30355
Fix issue with blocks being moved by frame motor where the server-side blocks may try to update their client counterparts before they are actually moved on the client.
- In previous logic, the server completes the entire move before client. The last step of the movement is to do neighbor updates, where block entities may update their client counterparts of their new state via packet.
- Now, movement is staggered across server and client in this order:
  - Server silently moves blocks and block entities without neighbor updates
  - Client completes full move
  - Server finishes move by performing block updates, etc
- As a byproduct, since nothing re-renders chunk until movement is fully complete on both sides, the rendering is extremely smooth in semi-blocking and blocking chunk modes :) (Threaded mode is smoother than before but still presents artifacts).

same issue as af30355, except for tiles

MrTJP added 2 commits May 31, 2024 11:15

fix: connectable tiles reconnecting on removal

15817a8

same issue as af30355, except for tiles

fix: server/client blocks getting out of sync during frame move

5409800

MrTJP changed the title ~~Bug fixes~~ Bug fixes and drastic improvement in frame move smoothness Jun 2, 2024

MrTJP merged commit 87aa5d8 into main Jun 18, 2024
2 checks passed

MrTJP deleted the patch-06022024 branch June 18, 2024 11:59

Provide feedback